Skip to content

Conversation

@manmartgarc
Copy link
Contributor

@manmartgarc manmartgarc commented Aug 17, 2025

  • Adds go vet call to the lint step in GA workflow.
  • Enforces a compatible go-version with the minimum in the matrix for the test step.
  • Fixes some minor .yml formatting

Fixes #281


There's some discussion in #281 about adding staticcheck as well but when I ran it, it found some hits (see below) that are presumably not severe, and I wouldn't want to block deployments before getting some feedback from maintainers.

internal/jsonrpc2/conn.go:695:4: this value of writeErr is never used (SA4006)
internal/jsonrpc2/conn.go:697:5: this value of err is never used (SA4006)
internal/jsonrpc2/conn.go:700:4: this value of err is never used (SA4006)
mcp/mcp_test.go:501:2: var resource3 is unused (U1000)
mcp/mcp_test.go:509:5: var embeddedResources is unused (U1000)
mcp/mcp_test.go:513:6: func handleEmbeddedResource is unused (U1000)
mcp/streamable.go:124:3: unnecessary assignment to the blank identifier (S1005)
mcp/streamable.go:291:2: field lastStreamID is unused (U1000)
mcp/streamable.go:293:2: field opts is unused (U1000)
mcp/streamable_test.go:542:29: argument ctx is overwritten before first use (SA4009)

- Adds `go vet` call to the lint step in GA workflow.
- Enforces a compatible `go-version` with the minimum in the matrix for
  the `test` step.

Fixes modelcontextprotocol#281
@manmartgarc manmartgarc marked this pull request as ready for review August 17, 2025 23:41
Copy link
Contributor

@jba jba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
If you're interested, you could look into those staticcheck hits.

@jba jba merged commit eb5eb06 into modelcontextprotocol:main Aug 18, 2025
5 checks passed
@manmartgarc manmartgarc deleted the ci-add-vet branch September 1, 2025 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lint issues in codebase

2 participants