mcp: minor cleanup of some TODOs #332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do a pass through TODOs to delete or address minor TODOs.
jba
previously approved these changes
Aug 20, 2025
mcp/features.go
Outdated
| // an ordering for the List calls, so what it calls a "list" is actually a set. | ||
| // TODO: switch to an ordered map | ||
| // | ||
| // An alternative implementation would use an ordered map, but that's probable |
Contributor
Author
There was a problem hiding this comment.
Done. (Needs re-approval now)
jba
approved these changes
Aug 20, 2025
yasomaru
pushed a commit
to yasomaru/go-sdk
that referenced
this pull request
Aug 28, 2025
Do a pass through TODOs to delete or address minor TODOs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do a pass through TODOs to delete or address minor TODOs.