Skip to content

mcp: example middleware wrapping ToolHandler #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 22, 2025
Merged

mcp: example middleware wrapping ToolHandler #351

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a03d62
mcp: example middleware wrapping ToolHandler
jba Aug 22, 2025
64073ea
fix test
jba Aug 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions mcp/example_middleware_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,13 +40,16 @@ func Example_loggingMiddleware() {
"session_id", req.GetSession().ID(),
"has_params", req.GetParams() != nil,
)
// Log more for tool calls.
if ctr, ok := req.(*mcp.CallToolRequest); ok {
logger.Info("Calling tool",
"name", ctr.Params.Name,
"args", ctr.Params.Arguments)
}

start := time.Now()

result, err := next(ctx, method, req)

duration := time.Since(start)

if err != nil {
logger.Error("MCP method failed",
"method", method,
Expand All @@ -62,7 +65,6 @@ func Example_loggingMiddleware() {
"has_result", result != nil,
)
}

return result, err
}
}
Expand Down Expand Up @@ -134,6 +136,7 @@ func Example_loggingMiddleware() {
// time=2025-01-01T00:00:00Z level=INFO msg="MCP method started" method=notifications/initialized session_id="" has_params=true
// time=2025-01-01T00:00:00Z level=INFO msg="MCP method completed" method=notifications/initialized session_id="" duration_ms=0 has_result=false
// time=2025-01-01T00:00:00Z level=INFO msg="MCP method started" method=tools/call session_id="" has_params=true
// time=2025-01-01T00:00:00Z level=INFO msg="Calling tool" name=greet args="{\"name\":\"World\"}"
// time=2025-01-01T00:00:00Z level=INFO msg="MCP method completed" method=tools/call session_id="" duration_ms=0 has_result=true
// Tool result: Hello, World!
}