mcp: cleanup transport after keepalive ping fails #360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h9jiang
commented
Aug 22, 2025
| getServer func(*http.Request) *Server | ||
| opts StreamableHTTPOptions | ||
|
|
||
| onTransportDeletion func(sessionID string) // for testing only |
Collaborator
Author
There was a problem hiding this comment.
I would prefer not to add this field only for testing purpose. But the test need some signal from the production indicating transportations have changed.
Let me know if you have any better solution to this.
An onClose function is passed to the ServerSession and ClientSession to help cleanup resources from the caller. The onClose function will be executed as part of the ServerSession and ClientSession closure. Fixes modelcontextprotocol#258
findleyr
reviewed
Aug 22, 2025
Contributor
findleyr
left a comment
findleyr
left a comment
There was a problem hiding this comment.
Thanks! This essentially LGTM, but a couple superficial comments.
- remove unnecessary lock for sending channel - add todo to refactor the bind method
findleyr
approved these changes
Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An onClose function is passed to the ServerSession and ClientSession to help cleanup resources from the caller.
The onClose function will be executed as part of the ServerSession and ClientSession closure.
Fixes #258