Skip to content

Existing MCP servers trigger panics for resource templates #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 25, 2025
Merged

Existing MCP servers trigger panics for resource templates #365

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
19fceb1
Don't panic for all resource syntax issues
slimslenderslacks Jul 31, 2025
6600780
panics for resourceTemplates as well
slimslenderslacks Aug 22, 2025
9a8084d
Stop parsing urls of resource templates
slimslenderslacks Aug 25, 2025
91d1e89
remove failing scheme test
slimslenderslacks Aug 25, 2025
72beaff
simplify expression
slimslenderslacks Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 3 additions & 13 deletions mcp/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
"iter"
"maps"
"net/url"
"os"

Check failure on line 17 in mcp/server.go

View workflow job for this annotation

GitHub Actions / race-test 

"os" imported and not used

Check failure on line 17 in mcp/server.go

View workflow job for this annotation

GitHub Actions / test (1.25.0-rc.3) 

"os" imported and not used

Check failure on line 17 in mcp/server.go

View workflow job for this annotation

GitHub Actions / test (1.23) 

"os" imported and not used

Check failure on line 17 in mcp/server.go

View workflow job for this annotation

GitHub Actions / test (1.24) 

"os" imported and not used
"path/filepath"
"reflect"
"slices"
Expand Down Expand Up @@ -345,13 +346,10 @@
func (s *Server) AddResource(r *Resource, h ResourceHandler) {
s.changeAndNotify(notificationResourceListChanged, &ResourceListChangedParams{},
func() bool {
u, err := url.Parse(r.URI)
_, err := url.Parse(r.URI)
Copy link
Contributor

@jba jba Aug 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: if _, err := ...; err != nil

Copy link
Contributor Author

@slimslenderslacks slimslenderslacks Aug 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh ya! Updated that

if err != nil {
panic(err) // url.Parse includes the URI in the error
}
if !u.IsAbs() {
panic(fmt.Errorf("URI %s needs a scheme", r.URI))
}
}
s.resources.add(&serverResource{r, h})
return true
})
Expand All @@ -374,14 +372,6 @@
if err != nil {
panic(fmt.Errorf("URI template %q is invalid: %w", t.URITemplate, err))
}
// Ensure the URI template has a valid scheme
u, err := url.Parse(t.URITemplate)
if err != nil {
panic(err) // url.Parse includes the URI in the error
}
if !u.IsAbs() {
panic(fmt.Errorf("URI template %q needs a scheme", t.URITemplate))
}
s.resourceTemplates.add(&serverResourceTemplate{t, h})
return true
})
Expand Down
Loading