transport.go: disable stdio batching for newer protocols #453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samthanawalla
force-pushed
the
removeBatchingStdio
branch
from
2ff41bc to
062067b
Compare
samthanawalla
changed the title
findleyr
reviewed
Sep 11, 2025
Contributor
findleyr
left a comment
findleyr
left a comment
There was a problem hiding this comment.
Looks good, just a couple comments. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR disables batching support for stdio by storing the negotiated protocol version and comparing it to protocolVersion20250618.
Fixes: #21