mcp: implement completion #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jba
requested changes
Jun 26, 2025
This CL implements a completion handler for the server and a complete method for the client.
samthanawalla
force-pushed
the
addCompletion
branch
from
ce247f8 to
2f08b61
Compare
jba
previously approved these changes
Jun 30, 2025
SamMorrowDrums
suggested changes
Jun 30, 2025
SamMorrowDrums
approved these changes
Jul 1, 2025
jba
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL implements a completion handler for the server and a complete method for the client.
Fixes: #12
Motivation and Context
This adds support for completion.
How Has This Been Tested?
Added tests and an example.
Breaking Changes
N/A
Types of changes
Checklist
Additional context