mcp: new API for features #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This PR has two commits which can be reviewed independently: one for tools, and one for everything else. |
jba
requested review from
findleyr and
samthanawalla
and removed request for
findleyr
Contributor
|
This looks great! However, could you update the design doc? (gemini CLI can do a pretty good job of this for you) I think it's confusing if the APIs do not match the design, especially at such an early phase when things are subject to change. |
Contributor
Author
|
Design doc updated. And you were right, gemini CLI was impressive. |
findleyr
approved these changes
Jul 3, 2025
Contributor
findleyr
left a comment
findleyr
left a comment
There was a problem hiding this comment.
Looks great. Thanks again.
Contributor
Author
|
@samthanawalla you have to approve for me to merge. I guess to assert that I addressed your changes to your satisfaction. |
jba
requested review from
findleyr and
samthanawalla
and removed request for
samthanawalla
findleyr
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE
Change the API for adding tools, prompts, resources and resource templates to a server.
The ServerXXX types are gone along with the plural Add methods (AddTools, AddPrompts etc.)
Instead there are single Add methods (AddTool, AddPrompt).
In addition, instead of NewServerTool, there is AddTool[In, Out].
Fixes #73.