jsonchema: add cycle detection (#77) #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks. I agree, let's drop the caching and keep the cycle detection. |
jba
requested changes
Jul 7, 2025
albertsundjaja
changed the title
albertsundjaja
commented
Jul 10, 2025
| } | ||
| } | ||
|
|
||
| func TestForWithMutation(t *testing.T) { |
Contributor
Author
There was a problem hiding this comment.
context: I'm keeping this unit test, I think they are still good to have
jba
approved these changes
Jul 10, 2025
Contributor
|
Thanks for doing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add cycle detection where it return error instead of waiting for stack overflow
This is a fix for #77
The root cause of the issue was the type being processed is deeply nested and has cycle. Hence, the heap memory growth is faster than the stack growth, it went OOM before stack overflow panic can kick in