Skip to content

fix dark mode color and padding for the tab item#274

Merged
olaservo merged 2 commits intomodelcontextprotocol:mainfrom
nathanArseneau:dark-mode-fix
Apr 12, 2025
Merged

fix dark mode color and padding for the tab item#274
olaservo merged 2 commits intomodelcontextprotocol:mainfrom
nathanArseneau:dark-mode-fix

Conversation

@nathanArseneau
Copy link
Contributor

There were inconsistencies between the margins of all tabs.
Dark mode colors where not consistent

Motivation and Context

Adding consistency in the UI

How Has This Been Tested?

image image image image

Breaking Changes

No

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@cliffhall
Copy link
Member

@nathanArseneau the inconsistent tab gap was fixed with #265. Maybe you can resolve the conflicts and just make this PR handle the dark mode colors?

@cliffhall cliffhall added bug Something isn't working waiting on submitter Waiting for the submitter to provide more info and removed bug Something isn't working labels Apr 11, 2025
@nathanArseneau
Copy link
Contributor Author

Hello @cliffhall I removed the fix for the tab gap and resolved the conflicts
image
image
image

@olaservo olaservo merged commit 645a256 into modelcontextprotocol:main Apr 12, 2025
2 checks passed
IgnacioC44 referenced this pull request in MCPJam/inspector Jun 21, 2025
fix dark mode color and padding for the tab item
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting on submitter Waiting for the submitter to provide more info

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants