-
Notifications
You must be signed in to change notification settings - Fork 766
Add Auth debugger tab #355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 24 commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
454a609
wip auth debugger
pcarleton cc77b84
cleanup types and validation
pcarleton d11f2db
more cleanup
pcarleton be22205
draft test
pcarleton 19f01e1
wip clean up some
pcarleton 6277126
rm toasts
pcarleton ecefbdd
consolidate state management
pcarleton 2f8ab16
prettier
pcarleton 5158c22
hoist state up to App
pcarleton 5dca3ed
working with quick and guided
pcarleton cde4663
sort out displaying debugger
pcarleton 506d907
prettier
pcarleton f4664c7
cleanup types
pcarleton c46df44
fix tests
pcarleton c3a565f
cleanup comment
pcarleton f6053b0
prettier
pcarleton 779621e
fixup types in tests
pcarleton 8e8eb41
prettier
pcarleton 4a67d0c
refactor debug to avoid toasting
pcarleton cbe6324
callback shuffling
pcarleton f986114
linting
pcarleton 10cd3e2
types
pcarleton 50a4895
rm toast in test
pcarleton bcfb332
Merge branch 'main' into pcarleton/auth-debugger
pcarleton bf4b810
bump typescript sdk version to 0.11.2 for scope parameter passing
pcarleton 70b965f
use proper scope handling
pcarleton 415ca4c
test scope parameter passing
pcarleton fddcf8f
move functions and s/sseUrl/serverUrl/
pcarleton 79ef9ab
extract status message into component
pcarleton dc875a0
refactor progress and steps into components
pcarleton 0824277
fix test
pcarleton 6407465
rename quick handler
pcarleton f36c133
one less click
pcarleton 3ec4069
last step complete
pcarleton 78c9c21
add state machine
pcarleton adaa023
test and types
pcarleton 78ed3c7
Merge branch 'main' into pcarleton/auth-debugger
pcarleton File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
something for the follow up (for myself) - we need to support shttp as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
true, I think it should be pretty much the same because this all happens before any MCP protocol initialization.
I've been testing this on the python simple auth server, do we have a streamable http auth example? can modify the existing one to add it if not
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, it should be something like this: modelcontextprotocol/python-sdk#695 will test and publish the PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great, this seems to work.
One thing I didn't fully go through and update is the state parameter in App.tsx, it's still called
sseUrl
even though it can be either sse or streambleHttp. won't tackle that here, but wanted to mention while it's fresh.