Skip to content

Conversation

@dsp-ant
Copy link
Member

@dsp-ant dsp-ant commented Nov 4, 2024

Remove hardcoded path to example server from default args state, replacing with empty string. This makes the initial state more generic and allows users to specify their own server path without preset assumptions.

Remove hardcoded path to example server from default args state, replacing with empty string. This makes the initial state more generic and allows users to specify their own server path without preset assumptions.
Copy link
Member

@jspahrsummers jspahrsummers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The command path is still hardcoded. Did you want to remove that too?

I'm on the fence here generally, because I think it's good to show some example of how to use things here. (For example, knowing that ~/… won't work!)

@ashwin-ant
Copy link
Member

I think getting rid of the hardcoded part makes sense. Maybe we can have some example path as the placeholder field on the input instead?

@dsp-ant
Copy link
Member Author

dsp-ant commented Nov 5, 2024

For what it's worth, i saw it happening that when you run an MCP server that just doesn't take any args, the current behaviour is to refill the args with the default, which is kind of frustrating. The description on the input box already says: "Arguments (space-separated)"

@jspahrsummers
Copy link
Member

Ah, I think we should just solve that by distinguishing localStorage.getItem("lastArgs") returning an empty string vs. undefined/null.

@jspahrsummers
Copy link
Member

Superseded by #49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants