Separate error states per tab, clear errors when clicking around #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Would be great to include screenshots of whats going on in the PR. |
Member
Author
|
This is a bugfix for #40. A recording would just show how it should've behaved all along |
dsp-ant
approved these changes
Nov 12, 2024
Member
dsp-ant
left a comment
dsp-ant
left a comment
There was a problem hiding this comment.
Not gonna pretend i a understand what's going on.
Comment on lines
+204
to
+206
| } else { | ||
| setErrors((prev) => ({ ...prev, [tabKey]: (e as Error).message })); | ||
| } |
Member
There was a problem hiding this comment.
since we have a clearErrors would it make sense to have a setError that takes a specific tab key and sets the error?
Member
Author
There was a problem hiding this comment.
It would only be used in this and clearError, whereas the latter gets used in many more places. I'd prefer to keep it to this for now.
Member
Author
|
Added a video to the PR description |
dsp-ant
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CleanShot.2024-11-12.at.15.40.40.mp4