Skip to content

cli: allow custom URL endpoints for HTTP/SSE URLs #578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pztrick wants to merge 1 commit into from
Closed

cli: allow custom URL endpoints for HTTP/SSE URLs #578

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 18 additions & 8 deletions cli/src/transport.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,20 +15,30 @@ export type TransportOptions = {
};

function createSSETransport(options: TransportOptions): Transport {
const baseUrl = new URL(options.url ?? "");
const sseUrl = baseUrl.pathname.endsWith("/sse")
? baseUrl
: new URL("/sse", baseUrl);
if (!options.url) {
throw new Error("URL is required for SSE transport");
}

const sseUrl = new URL(options.url);

if (!sseUrl.pathname.endsWith("/sse")) {
console.warn(`[warn] SSE transport URL does not end with /sse: ${options.url}`);
}
Comment on lines +24 to +26
Copy link
Member

@cliffhall cliffhall Jul 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the focus of this PR, is it necessary to output this warning at all?


return new SSEClientTransport(sseUrl);
}

function createHTTPTransport(options: TransportOptions): Transport {
const baseUrl = new URL(options.url ?? "");
const mcpUrl = baseUrl.pathname.endsWith("/mcp")
? baseUrl
: new URL("/mcp", baseUrl);
if (!options.url) {
throw new Error("URL is required for HTTP transport");
}

const mcpUrl = new URL(options.url);

if (!mcpUrl.pathname.endsWith("/mcp")) {
console.warn(`[warn] HTTP transport URL does not end with /mcp: ${options.url}`);
}
Comment on lines +38 to +40
Copy link
Member

@cliffhall cliffhall Jul 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the focus of this PR, is it necessary to output this warning at all?


return new StreamableHTTPClientTransport(mcpUrl);
}

Expand Down
Loading