chore: Routing fragment only when connected #638
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardkmichael
changed the title
richardkmichael
force-pushed
the
routing-fragment-cleanup
branch
10 times, most recently
from
183143f to
3ab4ddc
Compare
- Only set URL fragment when mcpClient is connected - Set default fragment based on server capabilities priority (resources > prompts > tools > ping) - Clear fragment when disconnected to prevent stale routing state 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
…ndow mocking - Add tests for hash routing based on server capabilities priority - Test that no hash is set when disconnected - Add e2e test verifying startup has no hash fragment - Use Jest module mocking for useConnection hook states 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
richardkmichael
force-pushed
the
routing-fragment-cleanup
branch
from
bd39459 to
8de1122
Compare
richardkmichael
changed the title
richardkmichael
changed the title
olaservo
approved these changes
Jul 26, 2025
Member
olaservo
left a comment
olaservo
left a comment
There was a problem hiding this comment.
Thanks for the PR. I tested with a combination of:
- connected server with no Resources
- connected server with Resources
- not connected to a server
and this all looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#resourcesNote:
I had quite a few test failures in CI, but not locally, due test order execution differences. By formally randomizing test order (instead of a difference due to shell globbing or other CI-specific differences), Jest will output a seed value which can be used locally.
Future work can refactor the tests, there is now duplication
Motivation and Context
The tabs for MCP components only display when connected to a server, so there is no
Resourcestab available on initial open of the Inspector. The Inspector has numerous configuration options and also remembers state (vialocalStorage), so displaying a routing fragment when it is not relevant can be confusing and suggest a state or configuration bug.How Has This Been Tested?
React and Playwright tests added. Tested locally as well.
Breaking Changes
Seems unlikely.
Types of changes
Not sure how to categorize; I consider this a "UX bug".
Checklist