Skip to content

Parse tool args from CLI as JsonValue instead of just strings #647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
+700 −78
Open

Parse tool args from CLI as JsonValue instead of just strings #647

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
99b962d
Parse tool args from CLI as JsonValue instead of just strings
olaservo Jul 26, 2025
50db045
Merge branch 'main' into parse-tool-arg
olaservo Jul 27, 2025
6ce4a0b
Fix formatting
olaservo Jul 27, 2025
491a8dc
Add separate tool tests
olaservo Jul 27, 2025
6a2dcb0
Add CLI tool tests in CI
olaservo Jul 28, 2025
6e665b5
Merge branch 'main' into parse-tool-arg
olaservo Aug 2, 2025
dbacec6
Fix formatting
olaservo Aug 2, 2025
55edb40
Merge branch 'main' into parse-tool-arg
olaservo Aug 3, 2025
30a7d5e
Merge branch 'main' into parse-tool-arg
olaservo Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ client/tsconfig.app.tsbuildinfo
client/tsconfig.node.tsbuildinfo
cli/build
test-output
tool-test-output
# symlinked by `npm run link:sdk`:
sdk
client/playwright-report/
Expand Down
4 changes: 3 additions & 1 deletion cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,9 @@
"scripts": {
"build": "tsc",
"postbuild": "node scripts/make-executable.js",
"test": "node scripts/cli-tests.js"
"test": "node scripts/cli-tests.js && node scripts/cli-tool-tests.js",
"test:cli": "node scripts/cli-tests.js",
"test:cli-tools": "node scripts/cli-tool-tests.js"
},
"devDependencies": {},
"dependencies": {
Expand Down
62 changes: 0 additions & 62 deletions cli/scripts/cli-tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,6 @@ console.log(`${colors.BLUE}- Environment variables (-e)${colors.NC}`);
console.log(`${colors.BLUE}- Config file (--config)${colors.NC}`);
console.log(`${colors.BLUE}- Server selection (--server)${colors.NC}`);
console.log(`${colors.BLUE}- Method selection (--method)${colors.NC}`);
console.log(
`${colors.BLUE}- Tool-related options (--tool-name, --tool-arg)${colors.NC}`,
);
console.log(`${colors.BLUE}- Resource-related options (--uri)${colors.NC}`);
console.log(
`${colors.BLUE}- Prompt-related options (--prompt-name, --prompt-args)${colors.NC}`,
Expand Down Expand Up @@ -533,65 +530,6 @@ async function runTests() {
"tools/list",
);

console.log(
`\n${colors.YELLOW}=== Running Tool-Related Tests ===${colors.NC}`,
);

// Test 12: CLI mode with tool call
await runBasicTest(
"tool_call",
TEST_CMD,
...TEST_ARGS,
"--cli",
"--method",
"tools/call",
"--tool-name",
"echo",
"--tool-arg",
"message=Hello",
);

// Test 13: CLI mode with tool call but missing tool name (should fail)
await runErrorTest(
"missing_tool_name",
TEST_CMD,
...TEST_ARGS,
"--cli",
"--method",
"tools/call",
"--tool-arg",
"message=Hello",
);

// Test 14: CLI mode with tool call but invalid tool args format (should fail)
await runErrorTest(
"invalid_tool_args",
TEST_CMD,
...TEST_ARGS,
"--cli",
"--method",
"tools/call",
"--tool-name",
"echo",
"--tool-arg",
"invalid_format",
);

// Test 15: CLI mode with multiple tool args
await runBasicTest(
"multiple_tool_args",
TEST_CMD,
...TEST_ARGS,
"--cli",
"--method",
"tools/call",
"--tool-name",
"add",
"--tool-arg",
"a=1",
"b=2",
);

console.log(
`\n${colors.YELLOW}=== Running Resource-Related Tests ===${colors.NC}`,
);
Expand Down
Loading