Fix OAuth token_endpoint_auth_method to comply with OpenID Connect spec #660
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the OAuth client authentication method to comply with the OpenID Connect specification by changing
token_endpoint_auth_method
from"none"
to"client_secret_basic"
.Motivation and Context
The current implementation hardcodes
token_endpoint_auth_method
as"none"
in the client metadata, which violates the OpenID Connect specification. According to the spec, the default value should be"client_secret_basic"
. This incorrect value causes dynamic client registration to fail during the token generation phase because:token_endpoint_auth_method: "none"
How Has This Been Tested?
Breaking Changes
This is a non-breaking change that fixes incorrect behavior. Existing implementations that were somehow working with
"none"
may need to ensure their authorization servers supportclient_secret_basic
authentication, but this is the standard expected behavior.Types of changes
Checklist
Additional context
This change aligns the MCP Inspector with the OpenID Connect Core 1.0 specification (Section 9), which defines
client_secret_basic
as the default authentication method for confidential clients. The fix ensures proper client authentication during the OAuth 2.0 authorization code flow, preventing token exchange failures that were occurring with the previous"none"
setting.