Skip to content

Conversation

@crondinini-ant
Copy link
Contributor

@crondinini-ant crondinini-ant commented Oct 10, 2025

Motivation and Context

Some MCP servers support static client registration instead of dynamic, in which case the inspector needs to be able to provide a client secret for the connection.

This PR adds an optional Client Secret field below the Client ID option.

How Has This Been Tested?

Ran the inspector locally and connected to another server locally that had static client configured.

image

Breaking Changes

There should be no breaking change

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New(feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

@github-actions
Copy link

github-actions bot commented Oct 10, 2025

🎭 Playwright E2E Test Results

✅  24 passed

Details

24 tests across 3 suites
 29.1 seconds
 982e10d
ℹ️  Test Environment: Ubuntu Latest, Node.js v22.20.0
Browsers: Chromium, Firefox

📊 View Detailed HTML Report (download artifacts)

@crondinini-ant crondinini-ant marked this pull request as ready for review October 10, 2025 19:15
Copy link
Member

@cliffhall cliffhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Observed that Client Secret field

  • appears just below Client Id in Auth pleat on sidebar
  • defaults to password style
  • can be toggled to plaintext
  • is stored alongside Client Id in local storage,
  • is updated when the field changes
  • is present when reloading the browser
  • LGTM! 👍
Image

@cliffhall cliffhall merged commit 5d0d1c0 into main Oct 10, 2025
8 checks passed
@cliffhall cliffhall deleted the crondinini/support-client-secret branch October 10, 2025 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants