Skip to content

Conversation

Aliaksie
Copy link
Contributor

@Aliaksie Aliaksie commented Apr 9, 2025

adds utility method to findAvailablePort for tests

Has This Been Tested?

yes

Breaking Changes

no

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

Aliaksie added 5 commits April 9, 2025 19:43
# Conflicts:
#	mcp-spring/mcp-spring-webflux/src/test/java/io/modelcontextprotocol/WebFluxSseIntegrationTests.java
#	mcp/src/test/java/io/modelcontextprotocol/server/transport/HttpServletSseServerTransportProviderIntegrationTests.java
@tzolov tzolov self-assigned this Apr 15, 2025
tzolov pushed a commit that referenced this pull request Apr 15, 2025
- Add TestUtil class with findAvailablePort() method to the mcp-test module
- Add findAvailablePort() method to TomcatTestUtil classes
- Replace hardcoded port numbers with dynamic port allocation

Signed-off-by: Christian Tzolov <[email protected]>
@tzolov
Copy link
Contributor

tzolov commented Apr 15, 2025

Thanks @Aliaksie ,
In the future could you please pull rebase rather than merge with master (e.g. use something like git pull -r origin main) .

@tzolov
Copy link
Contributor

tzolov commented Apr 15, 2025

Cheery-picked, rebased, moved the TestUtils to the mcp-test.
merged at 263e374

@tzolov tzolov closed this Apr 15, 2025
@Aliaksie
Copy link
Contributor Author

Thanks @Aliaksie , In the future could you please pull rebase rather than merge with master (e.g. use something like git pull -r origin main) .

Hey @tzolov , Thanks for letting me know about this, I didn't know about this rule... I'll follow it now!

@Aliaksie Aliaksie deleted the feat/findAvailablePort branch April 15, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants