Skip to content

Improve error handling for message enqueue failure #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Improve error handling for message enqueue failure #283

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
59cebe0
Improve error handling for message enqueue failure
codeboyzhou May 30, 2025
3daa4bf
Merge branch 'modelcontextprotocol:main' into main
codeboyzhou Jun 10, 2025
c007093
Merge branch 'modelcontextprotocol:main' into main
codeboyzhou Jun 17, 2025
afc037b
Merge branch 'modelcontextprotocol:main' into main
codeboyzhou Jun 25, 2025
4d5eaad
Merge branch 'modelcontextprotocol:main' into main
codeboyzhou Jul 8, 2025
b4aba59
Merge branch 'modelcontextprotocol:main' into main
codeboyzhou Jul 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions mcp/src/main/java/io/modelcontextprotocol/server/transport/StdioServerTransportProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,7 @@
import java.io.InputStream;
import java.io.InputStreamReader;
import java.io.OutputStream;
import java.io.Reader;
import java.nio.charset.StandardCharsets;
import java.util.Map;
import java.util.concurrent.Executors;
import java.util.concurrent.atomic.AtomicBoolean;
import java.util.function.Function;
Expand Down Expand Up @@ -148,14 +146,12 @@ public StdioMcpSessionTransport() {

@Override
public Mono<Void> sendMessage(McpSchema.JSONRPCMessage message) {

return Mono.zip(inboundReady.asMono(), outboundReady.asMono()).then(Mono.defer(() -> {
if (outboundSink.tryEmitNext(message).isSuccess()) {
Sinks.EmitResult result = outboundSink.tryEmitNext(message);
if (result.isSuccess()) {
return Mono.empty();
}
else {
return Mono.error(new RuntimeException("Failed to enqueue message"));
}
return Mono.error(new RuntimeException("Failed to enqueue message: " + message + ", due to " + result));
}));
}

Expand Down
Loading