Skip to content

Conversation

@YunKuiLu
Copy link

@YunKuiLu YunKuiLu commented Jun 28, 2025

  • Added optional title field to resource, tool, prompt
  • Use builder pattern for easier field addition in the future

Motivation and Context

The following MCP spec PR adds a human-readable title field, and it needs to be implemented in the java-sdk.
modelcontextprotocol/modelcontextprotocol#663

PR #343 added a title to McpSchema.Implementation, so in this PR, I didn't make changes to this class.

How Has This Been Tested?

used unit test

Breaking Changes

The field is optional.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@YunKuiLu YunKuiLu marked this pull request as ready for review June 28, 2025 11:40
YunKuiLu added 3 commits June 28, 2025 23:58
# Conflicts:
#	mcp/src/main/java/io/modelcontextprotocol/spec/McpSchema.java
- add backwards-compatibility for Tool
- Added unit tests

Signed-off-by: YunKui Lu <[email protected]>
@YunKuiLu
Copy link
Author

YunKuiLu commented Jul 1, 2025

resolve conflict

@tzolov tzolov added the duplicate This issue or pull request already exists label Jul 14, 2025
@tzolov tzolov self-assigned this Jul 14, 2025
@tzolov
Copy link
Contributor

tzolov commented Jul 14, 2025

@YunKuiLu thank you for the submission.
I believe this has already been resoled by #372
I'm closing this issue as a duplicate. But feel free to submit another one if you find something missing.

@tzolov tzolov closed this Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

duplicate This issue or pull request already exists

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants