Skip to content

refactor: Replace string concatenation with {} placeholders in log statements #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

refactor: Replace string concatenation with {} placeholders in log statements #384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions mcp/src/main/java/io/modelcontextprotocol/client/transport/StdioClientTransport.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ private void startInboundProcessing() {
}
catch (Exception e) {
if (!isClosing) {
logger.error("Error processing inbound message for line: " + line, e);
logger.error("Error processing inbound message for line: {}", line, e);
}
break;
}
Expand Down Expand Up @@ -366,7 +366,7 @@ public Mono<Void> closeGracefully() {
}
})).doOnNext(process -> {
if (process.exitValue() != 0) {
logger.warn("Process terminated with code " + process.exitValue());
logger.warn("Process terminated with code {}", process.exitValue());
}
else {
logger.info("MCP server process stopped");
Expand Down
2 changes: 1 addition & 1 deletion mcp/src/test/java/io/modelcontextprotocol/spec/McpClientSessionTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ class McpClientSessionTests {
void setUp() {
transport = new MockMcpClientTransport();
session = new McpClientSession(TIMEOUT, transport, Map.of(),
Map.of(TEST_NOTIFICATION, params -> Mono.fromRunnable(() -> logger.info("Status update: " + params))));
Map.of(TEST_NOTIFICATION, params -> Mono.fromRunnable(() -> logger.info("Status update: {}", params))));
}

@AfterEach
Expand Down
Loading