Skip to content

Conversation

fengbaicanhe
Copy link
Contributor

change ping request handler, response empty map instead of empty string.

Motivation and Context

MCP Ping Specification
the ping response result field should be empty object:

{
  "jsonrpc": "2.0",
  "id": "123",
  "result": {}
}

How Has This Been Tested?

use mcp official tool npx @modelcontextprotocol/inspector, connect to mcp server and use ping for test.

Breaking Changes

no

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

@tzolov tzolov added this to the 0.8.0 milestone Mar 20, 2025
@tzolov tzolov added the bug Something isn't working label Mar 20, 2025
@tzolov tzolov self-assigned this Mar 20, 2025
@tzolov
Copy link
Contributor

tzolov commented Mar 20, 2025

Than you for catching this @fengbaicanhe

@tzolov
Copy link
Contributor

tzolov commented Mar 20, 2025

Updated, rebased and merged at cf0be36

@tzolov tzolov closed this Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants