Skip to content

try fix session potential leak by server sse ping #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −0
Open

try fix session potential leak by server sse ping #508

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ...ava/io/modelcontextprotocol/server/transport/WebMvcStreamableServerTransportProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,6 +295,13 @@ private ServerResponse handleGet(ServerRequest request) {
sseBuilder.onComplete(() -> {
logger.debug("SSE connection completed for session: {}", sessionId);
listeningStream.close();
// If the sse connection is closed,it means that the client
// connection has been disconnected
// due to network issues, etc.,
// and the session needs to be removed
if (sessionId != null) {
sessions.remove(sessionId);
}
});
}
}, Duration.ZERO);
Expand Down
Loading