Skip to content

Stateless server transport shouldn't require TEXT_EVENT_STREAM #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+7 −6
Closed

Stateless server transport shouldn't require TEXT_EVENT_STREAM #521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...c/main/java/io/modelcontextprotocol/server/transport/WebFluxStatelessServerTransport.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
* Implementation of a WebFlux based {@link McpStatelessServerTransport}.
*
* @author Dariusz Jędrzejczyk
* @author Yanming Zhou
*/
public class WebFluxStatelessServerTransport implements McpStatelessServerTransport {

Expand Down Expand Up @@ -100,8 +101,7 @@ private Mono<ServerResponse> handlePost(ServerRequest request) {
McpTransportContext transportContext = this.contextExtractor.extract(request, new DefaultMcpTransportContext());

List<MediaType> acceptHeaders = request.headers().asHttpHeaders().getAccept();
if (!(acceptHeaders.contains(MediaType.APPLICATION_JSON)
&& acceptHeaders.contains(MediaType.TEXT_EVENT_STREAM))) {
if (!acceptHeaders.contains(MediaType.APPLICATION_JSON)) {
return ServerResponse.badRequest().build();
}

Expand Down
4 changes: 2 additions & 2 deletions ...rc/main/java/io/modelcontextprotocol/server/transport/WebMvcStatelessServerTransport.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
* {@link io.modelcontextprotocol.server.transport.WebFluxStatelessServerTransport}
*
* @author Christian Tzolov
* @author Yanming Zhou
*/
public class WebMvcStatelessServerTransport implements McpStatelessServerTransport {

Expand Down Expand Up @@ -104,8 +105,7 @@ private ServerResponse handlePost(ServerRequest request) {
McpTransportContext transportContext = this.contextExtractor.extract(request, new DefaultMcpTransportContext());

List<MediaType> acceptHeaders = request.headers().asHttpHeaders().getAccept();
if (!(acceptHeaders.contains(MediaType.APPLICATION_JSON)
&& acceptHeaders.contains(MediaType.TEXT_EVENT_STREAM))) {
if (!acceptHeaders.contains(MediaType.APPLICATION_JSON)) {
return ServerResponse.badRequest().build();
}

Expand Down
5 changes: 3 additions & 2 deletions ...in/java/io/modelcontextprotocol/server/transport/HttpServletStatelessServerTransport.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
*
* @author Christian Tzolov
* @author Dariusz Jędrzejczyk
* @author Yanming Zhou
*/
@WebServlet(asyncSupported = true)
public class HttpServletStatelessServerTransport extends HttpServlet implements McpStatelessServerTransport {
Expand Down Expand Up @@ -126,9 +127,9 @@ protected void doPost(HttpServletRequest request, HttpServletResponse response)
McpTransportContext transportContext = this.contextExtractor.extract(request, new DefaultMcpTransportContext());

String accept = request.getHeader(ACCEPT);
if (accept == null || !(accept.contains(APPLICATION_JSON) && accept.contains(TEXT_EVENT_STREAM))) {
if (accept == null || !accept.contains(APPLICATION_JSON)) {
this.responseError(response, HttpServletResponse.SC_BAD_REQUEST,
new McpError("Both application/json and text/event-stream required in Accept header"));
new McpError("application/json required in Accept header"));
return;
}

Expand Down
Loading