Skip to content

Update signing key environment variable #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2025
Merged

Update signing key environment variable #283

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion buildSrc/src/main/kotlin/mcp.publishing.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ mavenPublishing {
}

private fun Project.configureSigning(mavenPublishing: MavenPublishBaseExtension) {
val gpgKeyName = "GPG_SIGNING_KEY"
val gpgKeyName = "GPG_SECRET_KEY"
val gpgPassphraseName = "SIGNING_PASSPHRASE"
val signingKey = providers.environmentVariable(gpgKeyName)
.orElse(providers.gradleProperty(gpgKeyName))
Comment on lines +49 to 52
Copy link

Copilot AI Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the expected key from GPG_SIGNING_KEY to GPG_SECRET_KEY drops support for the previously recognized environment/Gradle property name and may break existing build environments despite the PR stating there are no breaking changes. Consider supporting both (preferring the new one) to preserve backward compatibility, e.g.: val gpgKeyNames = listOf("GPG_SECRET_KEY", "GPG_SIGNING_KEY"); val signingKey = gpgKeyNames.map { providers.environmentVariable(it).orElse(providers.gradleProperty(it)) }.reduce { acc, p -> acc.orElse(p) }. Or document the intentional breaking change.

Suggested change
val gpgKeyName = "GPG_SECRET_KEY"
val gpgPassphraseName = "SIGNING_PASSPHRASE"
val signingKey = providers.environmentVariable(gpgKeyName)
.orElse(providers.gradleProperty(gpgKeyName))
val gpgKeyNames = listOf("GPG_SECRET_KEY", "GPG_SIGNING_KEY")
val gpgPassphraseName = "SIGNING_PASSPHRASE"
val signingKey = gpgKeyNames
.map { providers.environmentVariable(it).orElse(providers.gradleProperty(it)) }
.reduce { acc, p -> acc.orElse(p) }

Copilot uses AI. Check for mistakes.
Expand Down
Loading