Skip to content

Conversation

@skarpovdev
Copy link
Contributor

@skarpovdev skarpovdev commented Oct 10, 2025

Motivation and Context

How Has This Been Tested?

Breaking Changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@skarpovdev skarpovdev marked this pull request as ready for review October 10, 2025 12:22
Copilot AI review requested due to automatic review settings October 10, 2025 12:22
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modifies the test infrastructure to use Docker containers for running TypeScript SDK tests, specifically addressing Docker compatibility issues on macOS by separating test execution into platform-specific jobs.

  • Replaces local TypeScript SDK cloning and process execution with Docker-based test runners
  • Updates CI workflow to run macOS tests separately from Docker-based JVM tests
  • Refactors test utilities to use testcontainers library for better container management

Reviewed Changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
kotlin-sdk-test/src/jvmTest/kotlin/io/modelcontextprotocol/kotlin/sdk/integration/utils/Dockerfile Adds Docker image definition for TypeScript SDK test environment
kotlin-sdk-test/src/jvmTest/kotlin/io/modelcontextprotocol/kotlin/sdk/integration/typescript/TsTestBase.kt Major refactor replacing local process execution with Docker container management
kotlin-sdk-test/src/jvmTest/kotlin/io/modelcontextprotocol/kotlin/sdk/integration/typescript/sse/*.kt Updates test classes to use new Docker-based infrastructure
kotlin-sdk-test/build.gradle.kts Adds testcontainers dependency
gradle/libs.versions.toml Adds testcontainers library version
.github/workflows/build.yml Splits CI into separate macOS and Ubuntu jobs with different test strategies

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@skarpovdev skarpovdev closed this Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants