Fix decimal separator format in calculator tool tests #315
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@kpavlov Ironically, to resolve the test errors occurring during the validate PR process, this PR must be force-merged. This PR includes fixes for incorrect test cases. |
skarpovdev
approved these changes
Oct 13, 2025
devcrocod
force-pushed
the
fix/test-calculator-format-and-tags
branch
from
eacc8be to
4f5ca7c
Compare
devcrocod
force-pushed
the
fix/test-calculator-format-and-tags
branch
from
bca63e4 to
ae3e11e
Compare
…com/maeryo/kotlin-sdk into fix/test-calculator-format-and-tags
devcrocod
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
DecimalFormatSymbolsto use period as decimal separator (Locale.US)testComplexInputSchemaTool:formattedResult:"11,000"→"11.000"tags: Added actual test values["test", "calculator", "integration"]testComplexNestedSchema:formattedResult:"0,00"→"0.00"Motivation
Standard Decimal Notation: Using a comma as a decimal separator could be confusing as it's commonly used for thousands separators in many locales. Standardizing on the period (
.) follows international conventions and makes the output clearer.Test Data Correction: During the Validate PR workflow for Add metadata support to callTool method #289, discovered that the
tagsarray in theexpectedContentvariable oftestComplexInputSchemaTool()was incorrectly set to an empty array, which didn't match the actual input values being tested.