Skip to content

Conversation

@devcrocod
Copy link
Contributor

Extracted WebSocket as an optional dependency of the core module

How Has This Been Tested?

Local test run

Breaking Changes

None

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Refactoring

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the WebSocket dependency from a public API dependency to an implementation dependency in the core module, making it an optional/internal detail rather than part of the public API surface.

Key Changes:

  • Changed WebSocket from api to implementation dependency in kotlin-sdk-core
  • Added explicit WebSocket implementation dependencies to modules that need it (server, client test, and core test)

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
kotlin-sdk-core/build.gradle.kts Changed ktor.server.websockets from api to implementation dependency
kotlin-sdk-server/build.gradle.kts Added explicit implementation dependency on ktor.server.websockets
kotlin-sdk-client/build.gradle.kts Added ktor.server.websockets to test dependencies
kotlin-sdk-test/build.gradle.kts Added ktor.server.websockets to test dependencies

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@devcrocod devcrocod force-pushed the devcrocod/redactor-websocket-dependency branch from 3eaadef to 3cb3cbd Compare October 28, 2025 09:24
@devcrocod devcrocod merged commit c5a254b into main Oct 28, 2025
4 checks passed
@devcrocod devcrocod deleted the devcrocod/redactor-websocket-dependency branch October 28, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants