Add server session id #381
Open
+191
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support requests proxying from server to session by id
kpavlov
reviewed
Nov 7, 2025
Comment on lines
+575
to
+576
| val session = getSessionOrThrow(sessionId) | ||
| return session.ping() |
Contributor
There was a problem hiding this comment.
I see a pattern! It makes sense to make a method like withSession(sessionId) { session -> ... }
| ) : this(serverInfo, options, { instructions }, block) | ||
|
|
||
| private val sessions = atomic(persistentListOf<ServerSession>()) | ||
| private val sessionRegistry = atomic(persistentMapOf<String, ServerSession>()) |
Contributor
There was a problem hiding this comment.
Let's create a class for a session registry with a Type alias for the sessionId type. To better comply with the Single Responsibility Principle and potentially implement atomic operations on the session
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Add ids for server sessions (auto generated when created)
Support methods proxying from server to server session by id
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context