Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/shared/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,10 @@ interface HasRequiredConfigMissingOptions {
userConfig?: DxtUserConfigValues;
}

function isInvalidSingleValue(value: unknown): boolean {
return value === undefined || value === null || value === "";
}

/**
* Check if an extension has missing required configuration
* @param manifest The extension manifest
Expand All @@ -203,10 +207,9 @@ export function hasRequiredConfigMissing({
if (configOption.required) {
const value = config[key];
if (
value === undefined ||
value === null ||
value === "" ||
(Array.isArray(value) && value.length === 0)
isInvalidSingleValue(value) ||
(Array.isArray(value) &&
(value.length === 0 || value.some(isInvalidSingleValue)))
) {
return true;
}
Expand Down
21 changes: 21 additions & 0 deletions test/config.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -408,6 +408,27 @@ describe("hasRequiredConfigMissing", () => {
expect(result).toBe(true);
});

it("should return true when required config is array with invalid values", () => {
const manifest: DxtManifest = {
...baseManifest,
user_config: {
paths: {
type: "string",
title: "Paths",
description: "File paths",
required: true,
multiple: true,
},
},
};

const result = hasRequiredConfigMissing({
manifest,
userConfig: { paths: [""] },
});
expect(result).toBe(true);
});

it("should return true when required config is empty array", () => {
const manifest: DxtManifest = {
...baseManifest,
Expand Down
Loading