[Server] refactor: registry loader #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soyuka
requested review from
CodeWithKyrian,
Nyholm and
chr-hertel
as code owners
chr-hertel
reviewed
Oct 20, 2025
Member
chr-hertel
left a comment
chr-hertel
left a comment
There was a problem hiding this comment.
Hey @soyuka - happy to see you here! :)
I think this PR makes a lot of sense and sorts some issues we saw already, thanks for that! Only minor comments from my end - didn't give it a test tho.
chr-hertel
changed the title
chr-hertel
requested changes
Oct 24, 2025
soyuka
force-pushed
the
registry/loader
branch
from
da9ab91 to
86e74b6
Compare
soyuka
force-pushed
the
registry/loader
branch
from
86e74b6 to
31428fb
Compare
Contributor
Author
|
my bad forgot to self-review I've also removed the |
chr-hertel
approved these changes
Oct 24, 2025
Member
chr-hertel
left a comment
chr-hertel
left a comment
There was a problem hiding this comment.
Nice one - thanks @soyuka!
This was referenced Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor capability registration in Server Builder using dedicated loaders. A solution for #74
Motivation and Context
The previous
Server/Builder.phpcontained extensive logic for registering capabilities (tools, resources, prompts) both manually and through discovery. This led to a large and less modularBuilderclass. This change aims to improve the architecture by introducing dedicated loader classes for capability registration.How Has This Been Tested?
Existing tests for server capabilities and discovery should cover the functionality. No new tests were added as this is a refactoring. Let me know if I should add some as I'm not sure this is going to be accepted I didn't wanted to put unnecessary energy into unit testing.
Breaking Changes
No breaking changes are expected as this is an internal refactoring. The public API of the
Server/Builderremains the same.Types of changes
Checklist
Additional context
This refactoring extracts the capability registration logic into
ArrayRegistryLoaderfor manual registrations andDiscoveryRegistryLoaderfor discovery-based registrations. Both implementRegistryLoaderInterface. TheServer/Buildernow orchestrates these loaders, leading to a more extensible design.