[Server] Add tool name validation for SEP-986 #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chr-hertel
requested review from
Copilot
and removed request for
CodeWithKyrian and
Nyholm
There was a problem hiding this comment.
Pull Request Overview
This PR implements tool name validation according to the SEP-986 specification. The validation ensures tool names contain only allowed characters (a-z, A-Z, 0-9, dots, hyphens, underscores, forward slashes) and do not exceed 64 characters in length.
Key changes:
- Added a
NameValidatorclass to validate tool names against the SEP-986 specification - Integrated validation into the
Registryto log warnings for invalid tool names - Standardized debug message formatting to use double quotes instead of single quotes
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Capability/Tool/NameValidator.php | New validator class implementing tool name validation with regex pattern |
| src/Capability/Registry.php | Integrated name validator and standardized logging message format |
| tests/Unit/Capability/Tool/NameValidatorTest.php | Comprehensive test coverage for valid and invalid tool name cases |
| tests/Unit/Capability/Registry/RegistryTest.php | Updated test expectations to match new quote format in log messages |
| tests/Inspector/InspectorSnapshotTestCase.php | Removed unnecessary type hint comment |
| phpstan.dist.neon | Added exception for missing iterable value types in tests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
chr-hertel
force-pushed
the
feat-tool-name-validation
branch
from
beafd6d to
964d7a3
Compare
chr-hertel
commented
Nov 7, 2025
Comment on lines
+18
to
+21
| - | ||
| identifier: missingType.iterableValue | ||
| path: tests/ | ||
|
|
Member
Author
There was a problem hiding this comment.
this is addressing array shapes for DataProvider methods in tests - i don't think there is any value in defining them since it is only PHPUnit consuming those arrays not user land code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #137