Introducing schema component #2
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving over php-mcp/schema which is based on 2025-03-26/schema.ts
Would still apply changes:
switching toreadonlyclassesconstruct,make,toArray,fromArrayandjsonSerializemy2cents: the array structure is needed for
json_encodeand therefore thejsonSerializethat's the main use case for converting into array - and we have three different ways of constructing those value objects, why?my proposal would be to reduce the amount of methods per class to three:
__construct(...)for developers to instantiatemake(array $data): staticfor creation from array datajsonSerialize(): array(this would reduce the need to array_map/toArray calls on subobjects since jsonSerialize works recursively)WDYT @CodeWithKyrian - am I missing something?
Still WIP