Fix README namespace imports for Quick Start example #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
approved these changes
Sep 4, 2025
chr-hertel
approved these changes
Sep 4, 2025
Member
|
@CodeWithKyrian looks like your commits are missing signatures => commit signing |
CodeWithKyrian
force-pushed
the
fix-readme-namespace-imports
branch
from
f3a72bd to
4198304
Compare
Contributor
Author
|
@chr-hertel Done that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The README's Quick Start example contained incorrect namespace and import paths that didn't match the actual codebase structure.
Solution
use PhpMcp\Server\Attributes\McpTool;touse Mcp\Capability\Attribute\McpTool;Schemaimport