add resource templates in example to make example complete #1021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vincent-pli <[email protected]>
vincent-pli
force-pushed
the
add-resource-template-to-example
branch
from
8cd8caa to
fdb8251
Compare
ihrpr
requested changes
Jul 21, 2025
There was a problem hiding this comment.
Thank you for improving the documentation!
Sorry for the delay in PR reviews. We changed the approach for README to get all code snippets from examples. This change needs to be done in examples/snippets/clients/stdio_client.py file and then run
uv run scripts/update_readme_snippets.py
felixweinberger
added
documentation
felixweinberger
added
the
needs maintainer action
felixweinberger
removed
the
needs more work
felixweinberger
removed
the
needs maintainer action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context