Add auth
to {SseServer,StreamableHttp}Parameters
#1028
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
auth
was missing from the {SseServer,StreamableHttp}Parameters types. I could see arguments against this (especially since it addsarbitrary_types_allowed=True
), but I think the pydantic types should include all server params.httpx_client_factory
could also be added, but honestly, I don't fully understand it so I didn't want to change that part.How Has This Been Tested?
Breaking Changes
In theory it won't break anything. The property added in {SseServer,StreamableHttp}Parameters is optional, so if it is not included, nothing breaks.
Auth
is also a relatively new parameter for sse_client and streamablehttp_client, so potentially not many people have utilized it yet.Types of changes
Checklist
Additional context