Skip to content

Fix Bug: request_meta is not available in server.request_context #103 #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 21, 2024
Merged

Fix Bug: request_meta is not available in server.request_context #103 #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
37f6a32
fix: use pydantic Field with alias for _meta fields
dsp-ant Dec 21, 2024
52e69ef
Fix deprecation warning
dsp-ant Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/mcp/server/sse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,9 +102,9 @@ async def connect_sse(self, scope: Scope, receive: Receive, send: Send):
self._read_stream_writers[session_id] = read_stream_writer
logger.debug(f"Created new session with ID: {session_id}")

sse_stream_writer, sse_stream_reader = anyio.create_memory_object_stream(
0, dict[str, Any]
)
sse_stream_writer, sse_stream_reader = anyio.create_memory_object_stream[
dict[str, Any]
](0)

async def sse_writer():
logger.debug("Starting SSE writer")
Expand Down
2 changes: 1 addition & 1 deletion src/mcp/shared/session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ async def _receive_loop(self) -> None:
)
responder = RequestResponder(
request_id=message.root.id,
request_meta=validated_request.root.params._meta
request_meta=validated_request.root.params.meta
if validated_request.root.params
else None,
request=validated_request,
Expand Down
8 changes: 4 additions & 4 deletions src/mcp/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
from typing import Any, Generic, Literal, TypeVar

from pydantic import BaseModel, ConfigDict, FileUrl, RootModel
from pydantic import BaseModel, ConfigDict, Field, FileUrl, RootModel
from pydantic.networks import AnyUrl

"""
Expand Down Expand Up @@ -39,14 +39,14 @@ class Meta(BaseModel):

model_config = ConfigDict(extra="allow")

_meta: Meta | None = None
meta: Meta | None = Field(alias="_meta", default=None)


class NotificationParams(BaseModel):
class Meta(BaseModel):
model_config = ConfigDict(extra="allow")

_meta: Meta | None = None
meta: Meta | None = Field(alias="_meta", default=None)
"""
This parameter name is reserved by MCP to allow clients and servers to attach
additional metadata to their notifications.
Expand Down Expand Up @@ -86,7 +86,7 @@ class Result(BaseModel):

model_config = ConfigDict(extra="allow")

_meta: dict[str, Any] | None = None
meta: dict[str, Any] | None = Field(alias="_meta", default=None)
"""
This result property is reserved by the protocol to allow clients and servers to
attach additional metadata to their responses.
Expand Down
Loading