-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Update routing for streamable HTTP to avoid 307 redirect #1115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihrpr
previously approved these changes
Jul 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
#781 is addressing the same issue, I'll add a similar test to this PR.
ihrpr
previously approved these changes
Jul 11, 2025
ihrpr
approved these changes
Jul 11, 2025
This was referenced Jul 11, 2025
Thank you for looking into the PR @ihrpr |
jimsantora
pushed a commit
to jimsantora/steam-librarian
that referenced
this pull request
Jul 29, 2025
- Updated import from `fastmcp` to `mcp.server.fastmcp` - Changed requirements.txt to use mcp==1.12.2 instead of fastmcp>=2.10.0 - Updated transport to streamable-http with proper environment configuration - Added FASTMCP_HOST=0.0.0.0 environment variable in Helm deployment This migration avoids the HTTP redirect bug documented in: modelcontextprotocol/python-sdk#1115 that was not fixed in fastmcp 2.0. The official SDK provides better control over HTTP routing and eliminates automatic redirect behavior. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
4 tasks
saqadri
pushed a commit
to saqadri/stdio-fixes
that referenced
this pull request
Aug 6, 2025
…tprotocol#1115) Co-authored-by: ihrpr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setup the endpoint for the streamable HTTP (
/mcp
) in the routing table as a route served by an ASGI app, instead of mounting it as a base path.Resolves: #732
As mentioned in MCP specification (version 2025-06-18):
This also aligns with JSON-RPC specification.
Motivation and Context
The change is required to avoid a 307 Temporary Redirect, from
/mcp
to/mcp/
endpoint, which currently happens. The redirect causes issues for several popular clients and also impedes hosting MCP servers behind proxy servers.How Has This Been Tested?
Tested locally and on a remote server with MCP clients.
Breaking Changes
The users who have MCP clients configured to consume the endpoint with a slash, e.g.
/mcp/
, will start experiencing a 307 Temporary redirect to the endpoint without the slash/mcp
.Types of changes
Checklist
Additional context