Skip to content

Expose RequestParams._meta in ClientSession.call_tool #1231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Expose RequestParams._meta in ClientSession.call_tool #1231

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7750c5f
feat: expose RequestParams._meta in ClientSession.call_tool
samchenatti Aug 3, 2025
16a171f
style: apply ruff format
samchenatti Aug 3, 2025
9b0efae
refactor: make _meta handling more readable
samchenatti Aug 4, 2025
d5c0549
fix: reorder meta argument to avoid a BC
samchenatti Aug 4, 2025
f021dec
Merge branch 'main' into expose_meta_in_tool_calling
samchenatti Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/mcp/client/session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,17 +287,20 @@ async def call_tool(
arguments: dict[str, Any] | None = None,
read_timeout_seconds: timedelta | None = None,
progress_callback: ProgressFnT | None = None,
*,
meta: dict[str, Any] | None = None,
) -> types.CallToolResult:
"""Send a tools/call request with optional progress callback support."""

_meta: types.ReadResourceRequestParams.Meta | None = None
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this ReadResourceRequestParams?

if meta is not None:
_meta = types.RequestParams.Meta(**meta)

result = await self.send_request(
types.ClientRequest(
types.CallToolRequest(
method="tools/call",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this, not needed as it's the default value

params=types.CallToolRequestParams(
name=name,
arguments=arguments,
),
params=types.CallToolRequestParams(name=name, arguments=arguments, _meta=_meta),
)
),
types.CallToolResult,
Expand Down
Loading