Add test for ProtectedResourceMetadataParsing #1236

yannj-fr · 2025-08-04T20:15:53Z

Motivation and Context

Add tests cases for insurring ProtectedResourceMetadata validation is correctly done

How Has This Been Tested?

with pytest

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Documentation update

Checklist

I have read the MCP Documentation
My code follows the repository's style guidelines
New and existing tests pass locally
I have added appropriate error handling
I have added or updated documentation as needed

tests/shared/test_auth.py

Kludex

This PR is not testing the fact that the new fields are supported. It's testing that the class is properly validated, which it seems we are testing Pydantic here. The same can be said about the tests above.

I think an ideal test would be to use the new added literal fields in an auth flow. But that's an issue that comes from before, because we actually don't have tests for it...

Anyway, I'm okay with either merging or closing this.

tests/shared/test_auth.py

Co-authored-by: Paul Carleton <[email protected]>

Actually, I don't think this is the way to go.

…resource checking

yannj-fr · 2025-08-06T08:44:28Z

@Kludex tests updated

tests/server/fastmcp/auth/test_auth_integration.py

yannj-fr · 2025-08-06T10:07:44Z

@Kludex done with the requested changes

tests/server/fastmcp/auth/test_auth_integration.py

tests/shared/test_auth.py

Kludex · 2025-08-06T10:08:58Z

Maybe we could benefit more if we move the test you added to a new file, so we can actually don't mix bad practices with good ones.

yannj-fr · 2025-08-06T10:15:06Z

I will create a separated file, actually could be directly in the test/server/auth/test_proctected_resource.py

tests/server/auth/test_protected_resource.py

tests/shared/test_auth.py

Co-authored-by: Marcelo Trylesinski <[email protected]>

yannj-fr · 2025-08-06T11:14:08Z

As per your advice, I removed the test that is just on the model, and fixed naming.
Just one question, it is not good practice to have test case in a class?

Kludex · 2025-08-06T11:17:56Z

Just one question, it is not good practice to have test case in a class?

I don't think you get anything from it, it's more often seen in old test suites and when using unittest (https://docs.python.org/3/library/unittest.html#basic-example).

I prefer to stick with what modern packages do: not have wrapper classes.

This is my opinion tho.

Outdated review, changes have been addressed.

felixweinberger

Looking through the discussion here all comments have been addressed as far as I can tell.

Thank you for this contribution @yannj-fr!

felixweinberger · 2025-09-23T11:08:44Z

Looks like we also need approval from an auth CODEOWNER to land this, @pcarleton mind taking another look?

* Add regression test for stateless request memory cleanup (modelcontextprotocol#1140) * Implement RFC9728 - Support WWW-Authenticate header by MCP client (modelcontextprotocol#1071) * Add streamable HTTP starlette example to Python SDK docs (modelcontextprotocol#1111) * fix markdown error in README in main (modelcontextprotocol#1147) * README - replace code snippets with examples - add lowlevel to snippets (modelcontextprotocol#1150) * README - replace code snippets with examples - streamable http (modelcontextprotocol#1155) * chore: don't allow users to create issues outside the templates (modelcontextprotocol#1163) * Tests(cli): Add coverage for helper functions (modelcontextprotocol#635) * Docs: Update CallToolResult parsing in README (modelcontextprotocol#812) Co-authored-by: Felix Weinberger <[email protected]> * docs: add pre-commit install guide on CONTRIBUTING.md (modelcontextprotocol#995) Co-authored-by: Felix Weinberger <[email protected]> * fix flaky fix-test_streamablehttp_client_resumption test (modelcontextprotocol#1166) * README - replace code snippets with examples -- auth examples (modelcontextprotocol#1164) * Support falling back to OIDC metadata for auth (modelcontextprotocol#1061) * Add CODEOWNERS file for sdk (modelcontextprotocol#1169) * fix flaky test test_88_random_error (modelcontextprotocol#1171) * Make sure `RequestId` is not coerced as `int` (modelcontextprotocol#1178) * Fix: Replace threading.Lock with anyio.Lock for Ray deployment compatibility (modelcontextprotocol#1151) * fix: fix OAuth flow request object handling (modelcontextprotocol#1174) * update codeowners group (modelcontextprotocol#1191) * fix: perform auth server metadata discovery fallbacks on any 4xx (modelcontextprotocol#1193) * server: skip duplicate response on CancelledError (modelcontextprotocol#1153) Co-authored-by: ihrpr <[email protected]> * Unpack settings in FastMCP (modelcontextprotocol#1198) * chore: Remove unused prompt_manager.py file (modelcontextprotocol#1229) Co-authored-by: Tapan Chugh <[email protected]> * Improved supported for ProtectedResourceMetadata (modelcontextprotocol#1235) Co-authored-by: Paul Carleton <[email protected]> * chore: Remove unused variable notification_options (modelcontextprotocol#1238) * Improve README around the Context object (modelcontextprotocol#1203) * fix: allow to pass `list[str]` to `token_endpoint_auth_signing_alg_values_supported` (modelcontextprotocol#1226) * Remove strict validation on `response_modes_supported` member of `OAuthMetadata` (modelcontextprotocol#1243) * Add pyright strict mode on the whole project (modelcontextprotocol#1254) * Consistent casing for default headers Accept and Content-Type (modelcontextprotocol#1263) * Update dependencies and fix type issues (modelcontextprotocol#1268) Co-authored-by: Marcelo Trylesinski <[email protected]> * fix: prevent async generator cleanup errors in StreamableHTTP transport (modelcontextprotocol#1271) Co-authored-by: David Soria Parra <[email protected]> * chore: uncomment .idea/ in .gitignore (modelcontextprotocol#1287) Co-authored-by: Claude <[email protected]> * docs: clarify streamable_http_path configuration when mounting servers (modelcontextprotocol#1172) * feat: Add CORS configuration for browser-based MCP clients (modelcontextprotocol#1059) Co-authored-by: Marcelo Trylesinski <[email protected]> Co-authored-by: Felix Weinberger <[email protected]> * Added Audio to FastMCP (modelcontextprotocol#1130) * fix: avoid uncessary retries in OAuth authenticated requests (modelcontextprotocol#1206) Co-authored-by: Felix Weinberger <[email protected]> * Add PATHEXT to default STDIO env vars in windows (modelcontextprotocol#1256) * fix: error too many values to unpack (expected 2) (modelcontextprotocol#1279) Signed-off-by: San Nguyen <[email protected]> Co-authored-by: Felix Weinberger <[email protected]> Co-authored-by: Felix Weinberger <[email protected]> * SDK Parity: Avoid Parsing Server Response for non-JsonRPCMessage Requests (modelcontextprotocol#1290) * types: Setting default value for method: Literal (modelcontextprotocol#1292) * changes structured temperature to not deadly (modelcontextprotocol#1328) * Update simple-resource example to use non-deprecated read_resource return type (modelcontextprotocol#1331) Co-authored-by: Claude <[email protected]> * docs: Update README to include link to API docs for modelcontextprotocol#1329 (modelcontextprotocol#1330) * Allow ping requests before initialization (modelcontextprotocol#1312) * Python lint: Ruff rules for pylint and code complexity (modelcontextprotocol#525) * Fix context injection for resources and prompts (modelcontextprotocol#1336) * fix(fastmcp): propagate mimeType in resource template list (modelcontextprotocol#1186) Co-authored-by: Felix Weinberger <[email protected]> * fix: allow elicitations accepted without content (modelcontextprotocol#1285) Co-authored-by: Olivier Schiavo <[email protected]> * Use --frozen in pre-commit config (modelcontextprotocol#1375) * Return HTTP 403 for invalid Origin headers (modelcontextprotocol#1353) * Add test for ProtectedResourceMetadataParsing (modelcontextprotocol#1236) Co-authored-by: Paul Carleton <[email protected]> Co-authored-by: Marcelo Trylesinski <[email protected]> Co-authored-by: Felix Weinberger <[email protected]> * Fastmcp logging progress example (modelcontextprotocol#1270) Co-authored-by: Felix Weinberger <[email protected]> * feat: add paginated list decorators for prompts, resources, and tools (modelcontextprotocol#1286) Co-authored-by: Claude <[email protected]> * Remove "unconditionally" from conditional description (modelcontextprotocol#1289) * Use streamable-http consistently in examples (modelcontextprotocol#1389) * feat: Add SDK support for SEP-1034 default values in elicitation schemas (modelcontextprotocol#1337) Co-authored-by: Tapan Chugh <[email protected]> Co-authored-by: Felix Weinberger <[email protected]> * Implementation of SEP 973 - Additional metadata + icons support (modelcontextprotocol#1357) * Merge upstream/main with custom filtering --------- Signed-off-by: San Nguyen <[email protected]> Co-authored-by: Felix Weinberger <[email protected]> Co-authored-by: yurikunash <[email protected]> Co-authored-by: Pamela Fox <[email protected]> Co-authored-by: Inna Harper <[email protected]> Co-authored-by: Marcelo Trylesinski <[email protected]> Co-authored-by: Ian Davenport <[email protected]> Co-authored-by: Dagang Wei <[email protected]> Co-authored-by: Felix Weinberger <[email protected]> Co-authored-by: Stanley Law <[email protected]> Co-authored-by: Luca Chang <[email protected]> Co-authored-by: leweng <[email protected]> Co-authored-by: Clare Liguori <[email protected]> Co-authored-by: lukacf <[email protected]> Co-authored-by: ihrpr <[email protected]> Co-authored-by: Tapan Chugh <[email protected]> Co-authored-by: Tapan Chugh <[email protected]> Co-authored-by: Yann Jouanin <[email protected]> Co-authored-by: Paul Carleton <[email protected]> Co-authored-by: Sreenath Somarajapuram <[email protected]> Co-authored-by: Omer Korner <[email protected]> Co-authored-by: joesavage-silabs <[email protected]> Co-authored-by: Gregory L <[email protected]> Co-authored-by: David Soria Parra <[email protected]> Co-authored-by: Moustapha Ebnou <[email protected]> Co-authored-by: Max Isbey <[email protected]> Co-authored-by: Claude <[email protected]> Co-authored-by: Jerome <[email protected]> Co-authored-by: xavier <[email protected]> Co-authored-by: keurcien <[email protected]> Co-authored-by: Tim Esler <[email protected]> Co-authored-by: San Nguyen <[email protected]> Co-authored-by: Justin Wang <[email protected]> Co-authored-by: jess <[email protected]> Co-authored-by: Peter Alexander <[email protected]> Co-authored-by: Reid Geyer <[email protected]> Co-authored-by: Eleftheria Stein-Kousathana <[email protected]> Co-authored-by: Christian Clauss <[email protected]> Co-authored-by: pchoudhury22 <[email protected]> Co-authored-by: owengo <[email protected]> Co-authored-by: Olivier Schiavo <[email protected]> Co-authored-by: Steve Billings <[email protected]> Co-authored-by: Mike Salvatore <[email protected]>

yannj-fr and others added 5 commits August 4, 2025 20:06

Improved supported for ProtectedResourceMetadata

f348481

formatting

39e7576

Add test for ProtectedResourceMetadata parsing

e3c1eef

typo fix

e4de61b

Merge branch 'main' into feature/expose-protected-resource-metadata

2b5cc94

yannj-fr requested review from a team and pcarleton August 4, 2025 20:15

fix precommit hook

12eddcc

yannj-fr marked this pull request as draft August 4, 2025 20:35

yannj-fr marked this pull request as ready for review August 4, 2025 20:36

pcarleton previously requested changes Aug 5, 2025

View reviewed changes

tests/shared/test_auth.py Outdated Show resolved Hide resolved

tests/shared/test_auth.py Outdated Show resolved Hide resolved

Kludex reviewed Aug 5, 2025

View reviewed changes

tests/shared/test_auth.py Outdated Show resolved Hide resolved

yannj-fr and others added 2 commits August 5, 2025 12:10

Update tests/shared/test_auth.py

e8bfe35

Co-authored-by: Paul Carleton <[email protected]>

Update tests/shared/test_auth.py

79e1b16

Co-authored-by: Paul Carleton <[email protected]>

Kludex previously approved these changes Aug 5, 2025

View reviewed changes

Merge branch 'main' into feature/expose-protected-resource-metadata

0967a9e

Add test for protected resources through .well-known/oauth-protected-…

32151a6

…resource checking

Kludex reviewed Aug 6, 2025

View reviewed changes

yannj-fr added 3 commits August 6, 2025 11:41

remove prints in the entire file

dd22d76

remove prints and change test class, use snapshot

149f752

removing uneeded assert on response code

1fea1f3

Kludex previously approved these changes Aug 6, 2025

View reviewed changes

tests/server/fastmcp/auth/test_auth_integration.py Show resolved Hide resolved

tests/server/fastmcp/auth/test_auth_integration.py Outdated Show resolved Hide resolved

tests/shared/test_auth.py Show resolved Hide resolved

separate test in a new file

154b754

yannj-fr dismissed Kludex’s stale review via 154b754 August 6, 2025 10:18

fix pre check commit

69238ad

Merge branch 'main' into feature/expose-protected-resource-metadata

23fa8d4

Kludex reviewed Aug 6, 2025

View reviewed changes

tests/server/auth/test_protected_resource.py Outdated Show resolved Hide resolved

tests/server/auth/test_protected_resource.py Outdated Show resolved Hide resolved

tests/shared/test_auth.py Show resolved Hide resolved

yannj-fr and others added 2 commits August 6, 2025 12:44

Update tests/server/auth/test_protected_resource.py

82852be

Co-authored-by: Marcelo Trylesinski <[email protected]>

Update tests/server/auth/test_protected_resource.py

0826232

Co-authored-by: Marcelo Trylesinski <[email protected]>

Kludex previously approved these changes Aug 6, 2025

View reviewed changes

remove uneeded test and rename methods

0b800fe

yannj-fr dismissed Kludex’s stale review via 0b800fe August 6, 2025 11:12

yannj-fr requested review from Kludex and pcarleton August 7, 2025 09:54

yannj-fr and others added 2 commits August 9, 2025 13:41

Merge branch 'main' into feature/expose-protected-resource-metadata

f791a82

Merge branch 'main' into feature/expose-protected-resource-metadata

1994475

felixweinberger approved these changes Sep 23, 2025

View reviewed changes

felixweinberger added the needs more eyes Needs alignment among maintainers whether this is something we want to add label Sep 23, 2025

pcarleton approved these changes Sep 23, 2025

View reviewed changes

pcarleton merged commit 20596e5 into modelcontextprotocol:main Sep 23, 2025
18 checks passed

Add test for ProtectedResourceMetadataParsing #1236

Add test for ProtectedResourceMetadataParsing #1236

Conversation

yannj-fr commented Aug 4, 2025

Motivation and Context

How Has This Been Tested?

Types of changes

Checklist

Uh oh!

Uh oh!

Uh oh!

Kludex left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

yannj-fr commented Aug 6, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yannj-fr commented Aug 6, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Kludex commented Aug 6, 2025

Uh oh!

yannj-fr commented Aug 6, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yannj-fr commented Aug 6, 2025

Uh oh!

Kludex commented Aug 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

felixweinberger left a comment

Choose a reason for hiding this comment

Uh oh!

felixweinberger commented Sep 23, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Kludex commented Aug 6, 2025 •

edited

Loading