Skip to content

SEP: Elicitation Enum Schema Improvements and Standards Compliance #1246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

SEP: Elicitation Enum Schema Improvements and Standards Compliance #1246

wants to merge 8 commits into from
+132 −14

Conversation

chughtapan
Copy link
Contributor

@chughtapan chughtapan commented Aug 7, 2025 •
edited
Loading

Motivation and Context

This PR implements the changes required to implement multi-select enums in modelcontextprotocol/modelcontextprotocol#1330

How Has This Been Tested?

All new and existing tests pass

Breaking Changes

No

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@chughtapan chughtapan mentioned this pull request Aug 11, 2025
Open
@felixweinberger felixweinberger added needs SEP Major changes to structs and features generally require a SEP to be approved. needs motivation When a PR is submitted without clear intent or motivation for the changes. labels Sep 23, 2025
felixweinberger
felixweinberger reviewed Sep 23, 2025
View reviewed changes
Copy link
Contributor

@felixweinberger felixweinberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @chughtapan thanks for this - I notice you've marked this as a SEP, those are generally for enhancements to the protocol itself i.e. at github.com/mode

Is this meant as an attachment to a SEP or do you plan on creating one?

@felixweinberger felixweinberger added the enhancement New feature or request label Sep 23, 2025
@chughtapan
Copy link
Contributor Author

Is this meant as an attachment to a SEP or do you plan on creating one?

Its an attachment for modelcontextprotocol/modelcontextprotocol#1330
Edited the PR description with the SEP link

@chughtapan chughtapan mentioned this pull request Oct 6, 2025
Draft
fix: restore deleted elicitation tests after merge
208c141 
The merge commit 6dc50e2 accidentally removed two test sections:
- Valid list[str] multi-select test in test_elicitation_with_optional_fields
- Complete test_elicitation_with_enum_titles test function

This commit restores both deleted tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixweinberger felixweinberger felixweinberger left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request needs motivation When a PR is submitted without clear intent or motivation for the changes. needs SEP Major changes to structs and features generally require a SEP to be approved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chughtapan @felixweinberger