Skip to content

Update dependencies and fix type issues #1268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Aug 14, 2025
Merged

Update dependencies and fix type issues #1268

merged 9 commits into from
Aug 14, 2025
+303 −286

Conversation

dsp-ant
Copy link
Member

@dsp-ant dsp-ant commented Aug 13, 2025

Summary

  • Updated Click dependency to 8.2.0 across all examples and projects
  • Updated httpx to 0.27.1 and uvicorn to 0.31.1 in main pyproject.toml
  • Fixed type issues in tests by adding proper variable declarations and type annotations
  • Improved CI matrix to test both lowest-direct and highest dependency resolution strategies

Test plan

  • All tests pass with updated dependencies
  • Type checking passes with pyright
  • CI matrix tests both dependency resolution modes
  • Examples still work with updated Click version

dsp-ant added 2 commits August 13, 2025 09:44
@dsp-ant
[tests] Fix generic parameters for Context
312a57c
@dsp-ant
Bump uvicorn version to something more recent
b5cfa82 
We are bumping to a uvicorn version that was released a year ago, which
should match Pydantic 2.11.
@dsp-ant dsp-ant requested review from a team as code owners August 13, 2025 14:22
@ihrpr
Copy link
Contributor

ihrpr commented Aug 13, 2025

CI is unhappy

@dsp-ant dsp-ant force-pushed the davidsp/fix-types branch 2 times, most recently from 3ebbe24 to 17d2892 Compare August 13, 2025 15:47
Kludex
Kludex reviewed Aug 13, 2025
View reviewed changes
@dsp-ant dsp-ant force-pushed the davidsp/fix-types branch from 17d2892 to 82f6bae Compare August 13, 2025 16:00
Kludex
Kludex reviewed Aug 13, 2025
View reviewed changes
Kludex
Kludex reviewed Aug 13, 2025
View reviewed changes
@dsp-ant dsp-ant force-pushed the davidsp/fix-types branch from 9f8f7ae to 4808018 Compare August 13, 2025 16:04
@dsp-ant dsp-ant requested review from Kludex and ihrpr August 13, 2025 16:05
@dsp-ant
Copy link
Member Author

dsp-ant commented Aug 13, 2025

CI happy

ihrpr
ihrpr approved these changes Aug 13, 2025
View reviewed changes
Copy link
Contributor

@ihrpr ihrpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ihrpr
Copy link
Contributor

ihrpr commented Aug 13, 2025

"Require status checks to pass" needs to be updated in rulesets

@dsp-ant dsp-ant merged commit 0926613 into main Aug 14, 2025
21 checks passed
@dsp-ant dsp-ant deleted the davidsp/fix-types branch August 14, 2025 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihrpr ihrpr ihrpr approved these changes

@pcarleton pcarleton Awaiting requested review from pcarleton pcarleton is a code owner automatically assigned from modelcontextprotocol/python-sdk-auth

@felixweinberger felixweinberger Awaiting requested review from felixweinberger felixweinberger is a code owner automatically assigned from modelcontextprotocol/python-sdk

@Kludex Kludex Awaiting requested review from Kludex

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dsp-ant @ihrpr @Kludex