Skip to content

fix: prevent async generator cleanup errors in StreamableHTTP transport #1271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 14, 2025
+2 −0
Merged

fix: prevent async generator cleanup errors in StreamableHTTP transport #1271

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0ec498
fix: explicit response cleanup in SSE handlers
mous222 Aug 13, 2025
47eda6d
Merge branch 'main' into fix/sse-response-cleanup
dsp-ant Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/mcp/client/streamable_http.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,7 @@ async def _handle_resumption_request(self, ctx: RequestContext) -> None:
ctx.metadata.on_resumption_token_update if ctx.metadata else None,
)
if is_complete:
await event_source.response.aclose()
break

async def _handle_post_request(self, ctx: RequestContext) -> None:
Expand Down Expand Up @@ -330,6 +331,7 @@ async def _handle_sse_response(
# If the SSE event indicates completion, like returning respose/error
# break the loop
if is_complete:
await response.aclose()
break
except Exception as e:
logger.exception("Error reading SSE stream:")
Expand Down
Loading