Skip to content

GitHub Actions: Test on Python 3.14 #1346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+196 −31
Open

GitHub Actions: Test on Python 3.14 #1346

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions .github/workflows/shared.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,17 +13,17 @@ jobs:
pre-commit:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5

- uses: astral-sh/setup-uv@v5
- uses: astral-sh/setup-uv@v6
with:
enable-cache: true
version: 0.7.2
version: 0.8.23

- name: Install dependencies
run: uv sync --frozen --all-extras --python 3.10

- uses: pre-commit/[email protected].0
- uses: pre-commit/[email protected].1
with:
extra_args: --all-files --verbose
env:
Expand All @@ -35,18 +35,18 @@ jobs:
continue-on-error: true
strategy:
matrix:
python-version: ["3.10", "3.11", "3.12", "3.13"]
python-version: ["3.10", "3.11", "3.12", "3.13", "3.14"]
dep-resolution: ["lowest-direct", "highest"]
os: [ubuntu-latest, windows-latest]

steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5

- name: Install uv
uses: astral-sh/setup-uv@v3
uses: astral-sh/setup-uv@v6
with:
enable-cache: true
version: 0.7.2
version: 0.8.23

- name: Install the project
run: uv sync --frozen --all-extras --python ${{ matrix.python-version }} --resolution ${{ matrix.dep-resolution }}
Expand All @@ -57,12 +57,12 @@ jobs:
readme-snippets:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5

- uses: astral-sh/setup-uv@v5
- uses: astral-sh/setup-uv@v6
with:
enable-cache: true
version: 0.7.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put this back.

Copy link
Contributor Author

@cclauss cclauss Sep 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/astral-sh/uv/releases/tag/0.8.11 Added Python 3.14rc2 and 0.8.12 speeds up zstandard performance.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can change the version, but there's no need to remove it.

We actually need to set this version in the pyproject.toml.

version: 0.8.23

- name: Install dependencies
run: uv sync --frozen --all-extras --python 3.10
Expand Down
8 changes: 5 additions & 3 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,14 @@ classifiers = [
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
"Programming Language :: Python :: 3.13",
"Programming Language :: Python :: 3.14",
]
dependencies = [
"anyio>=4.5",
"httpx>=0.27.1",
"httpx-sse>=0.4",
"pydantic>=2.11.0,<3.0.0",
"pydantic>=2.11.0,<3.0.0; python_version < '3.14'",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing the classifier above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Member

@Kludex Kludex Sep 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing on line 22.

    "Programming Language :: Python :: 3.14",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not going to commit to supporting 3.14 until after we got the tests to pass, but here we go...

"pydantic>=2.12.0b1,<3.0.0; python_version >= '3.14'",
"starlette>=0.27",
"python-multipart>=0.0.9",
"sse-starlette>=1.6.1",
Expand All @@ -45,7 +47,7 @@ mcp = "mcp.cli:app [cli]"

[tool.uv]
default-groups = ["dev", "docs"]
required-version = ">=0.7.2"
required-version = ">=0.8.23"

[dependency-groups]
dev = [
Expand All @@ -63,7 +65,7 @@ dev = [
docs = [
"mkdocs>=1.6.1",
"mkdocs-glightbox>=0.4.0",
"mkdocs-material[imaging]>=9.5.45",
"mkdocs-material[imaging]>=9.6.21",
"mkdocstrings-python>=1.12.2",
]

Expand Down
Loading
Loading