Skip to content

fix: Package configuration and documentation improvements #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 6, 2025
Merged

fix: Package configuration and documentation improvements #135

merged 2 commits into from
Jan 6, 2025

Conversation

dsp-ant
Copy link
Member

@dsp-ant dsp-ant commented Jan 6, 2025

Summary

Test plan

  • Verify mcp run config generates correct package configuration
  • Review updated documentation for accuracy and clarity

dsp-ant added 2 commits January 6, 2025 09:39
@dsp-ant
fix: #128 fix package in the generated mcp run config
c651d40 
During `mcp install` we are generating a config
that relies on `mcp run`. However `mcp` is only available
as a CLI command if we use the `cli` feature.

We need to specify that we want to install mcp
with the cli feature.

Fixes #128
@dsp-ant
chore: add .DS_Store to gitignore
0907378
@dsp-ant dsp-ant merged commit c02a295 into main Jan 6, 2025
4 checks passed
@dsp-ant dsp-ant deleted the davidsp/issue-128 branch January 6, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dsp-ant