Add comprehensive Unicode tests for streamable HTTP transport #1381
+244
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixweinberger
requested changes
Sep 26, 2025
felixweinberger
added
the
needs more work
- Test Unicode text transmission in both directions (client→server→client) - Verify Unicode handling in tool descriptions, arguments, and responses - Verify Unicode handling in prompt descriptions and content - Test with various Unicode scripts including Cyrillic, Chinese, Japanese, Korean, Arabic, Hebrew, Greek, emoji, and special characters - Use multiprocessing to run server in separate process (avoids ResourceWarnings) - Follow existing test patterns from test_streamable_http_manager.py
Consolidate multiprocessing, socket, and time imports at the top of the file rather than importing them locally within fixtures. The imports within run_unicode_server remain as they must be available in the separate process context.
pja-ant
force-pushed
the
tests/add-unicode-test
branch
from
e178f6e to
fad7e01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
We've seen quite a few issues related to Unicode handling and while things appear to work, I noticed that we don't actually have tests for this (there's an example server though). Thought it would be useful to have a test to point people to if they expect Unicode handling isn't working and just ensure it doesn't regress.
How Has This Been Tested?
Run the new test
Breaking Changes
N/A
Types of changes
Checklist