Strict types on the client side #285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kludex
commented
Mar 14, 2025
Comment on lines
-79
to
-90
| sampling = ( | ||
| types.SamplingCapability() if self._sampling_callback is not None else None | ||
| ) | ||
| roots = ( | ||
| types.RootsCapability( | ||
| # TODO: Should this be based on whether we | ||
| # _will_ send notifications, or only whether | ||
| # they're supported? | ||
| listChanged=True, | ||
| ) | ||
| if self._list_roots_callback is not None | ||
| else None |
There was a problem hiding this comment.
The None was never being used, given that in __init__ they have a default value.
dsp-ant
approved these changes
Mar 14, 2025
| from mcp.types import LATEST_PROTOCOL_VERSION | ||
|
|
||
| SUPPORTED_PROTOCOL_VERSIONS = [1, LATEST_PROTOCOL_VERSION] | ||
| SUPPORTED_PROTOCOL_VERSIONS: tuple[int, str] = (1, LATEST_PROTOCOL_VERSION) |
There was a problem hiding this comment.
We can actually make this a list of strings ony land remove the old 1. That predates official release and is long gone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.