-
Notifications
You must be signed in to change notification settings - Fork 2.6k
show_server_info #296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
show_server_info #296
Conversation
@Kludex can you review ? |
@dsp-ant can you look ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Kludex any opinions? I personally understand why you would want this, but i think it would be better suited in your application as either a call before starting the server or as an extension to the FastMCP server class. I appreciate the effort but would politely decline adding this.
I think it's more useful in the stdio case. Since nothing happens when you start the application. But on the HTTP, it will be a bit noisy... If it's in debug level then I think it's fine. |
ok i will change to debug |
7b317cd
to
b6380bb
Compare
@Kludex @dsp-ant moved it to helper method and class, I think its very useful, for example in my code when im using sse i will add a route that return this object in some route for example /info (like in rest api have swagger json doc) |
reping |
@ihrpr @jerome3o-anthropic can you review ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this!
Sorry for the delays in reviews. Suggested a few small changes as we should be good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does the output look like? I think we should be careful here, it's easier to add more stuff, but not that easy to remove usually.
…ix-typescript-demo docs: modify the TypeScript server demo
I am closing this out since we haven't made much progress. I think this is mostly on us for screwing up reviewing this properly. Sorry @barnuri . I think in general we are still interested in the feeature, but mindful that we shouldn't add the underlying types to src/mcp/types.py since that file reflects the official protocol. This is an SDK feature only. If you are interested in redoing this ontop of the current state of the repo, please do so and ping me either via the MCP Contributor discord or on the PR and I will get to it. Again, I am very sorry that we didn't review this in proper time and made the progress very slow. |
Motivation and Context
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context