Skip to content

Conversation

barnuri
Copy link
Contributor

@barnuri barnuri commented Mar 16, 2025

Motivation and Context

How Has This Been Tested?

Breaking Changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@barnuri barnuri requested a review from Kludex March 16, 2025 12:23
@barnuri
Copy link
Contributor Author

barnuri commented Mar 19, 2025

@Kludex can you review ?

@barnuri
Copy link
Contributor Author

barnuri commented Mar 27, 2025

@dsp-ant can you look ?

Copy link
Member

@dsp-ant dsp-ant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kludex any opinions? I personally understand why you would want this, but i think it would be better suited in your application as either a call before starting the server or as an extension to the FastMCP server class. I appreciate the effort but would politely decline adding this.

@Kludex
Copy link
Member

Kludex commented Mar 28, 2025

I think it's more useful in the stdio case. Since nothing happens when you start the application.

But on the HTTP, it will be a bit noisy...

If it's in debug level then I think it's fine.

@barnuri
Copy link
Contributor Author

barnuri commented Mar 28, 2025

ok i will change to debug

@barnuri barnuri requested a review from dsp-ant March 28, 2025 05:57
@barnuri
Copy link
Contributor Author

barnuri commented Mar 28, 2025

@Kludex @dsp-ant moved it to helper method and class, I think its very useful, for example in my code when im using sse i will add a route that return this object in some route for example /info (like in rest api have swagger json doc)
the idea of it is to have something simple without creating a client that can be easily visible
same for using stdio and then i will use the debug log
i hope you would like it :)

@barnuri
Copy link
Contributor Author

barnuri commented Apr 11, 2025

@Kludex @dsp-ant moved it to helper method and class, I think its very useful, for example in my code when im using sse i will add a route that return this object in some route for example /info (like in rest api have swagger json doc) the idea of it is to have something simple without creating a client that can be easily visible same for using stdio and then i will use the debug log i hope you would like it :)

reping

@barnuri
Copy link
Contributor Author

barnuri commented Apr 21, 2025

@dsp-ant @Kludex can you tell me what do you think ?

@barnuri
Copy link
Contributor Author

barnuri commented Apr 23, 2025

@ihrpr @jerome3o-anthropic can you review ?

Copy link
Contributor

@ihrpr ihrpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this!

Sorry for the delays in reviews. Suggested a few small changes as we should be good to go.

Copy link
Member

@Kludex Kludex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does the output look like? I think we should be careful here, it's easier to add more stuff, but not that easy to remove usually.

@barnuri barnuri requested review from Kludex and ihrpr May 28, 2025 12:21
gspencergoog pushed a commit to gspencergoog/mcp-python-sdk that referenced this pull request Jul 29, 2025
…ix-typescript-demo

docs: modify the TypeScript server demo
@dsp-ant
Copy link
Member

dsp-ant commented Aug 5, 2025

I am closing this out since we haven't made much progress. I think this is mostly on us for screwing up reviewing this properly. Sorry @barnuri . I think in general we are still interested in the feeature, but mindful that we shouldn't add the underlying types to src/mcp/types.py since that file reflects the official protocol. This is an SDK feature only. If you are interested in redoing this ontop of the current state of the repo, please do so and ping me either via the MCP Contributor discord or on the PR and I will get to it.

Again, I am very sorry that we didn't review this in proper time and made the progress very slow.

@dsp-ant dsp-ant closed this Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants