feat(client/sse): allow to set the timeout of POST /messages
#340
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Hello. I'm writing a plugin for langgenius/dify that can export
workflowson Dify as MCP Servers.Due to Dify's plugin mechanism, connecting to Dify's cloud edition via HTTP takes a longer time. The
GET /sseendpoint can set a timeout through the parameters of thesse_clientmethod, while thePOST /messagesendpoint cannot, which results in the handshake phase not functioning properly.So I reused the parameters
readandsse_read_timeoutof thesse_cientmethod as timeout settings forPOST/messages.How Has This Been Tested?
before: failed fast in 5s for timeout
after: ok for handshake phase (404 for
/messagesendpoint not fully implemented)Breaking Changes
None
Types of changes
Checklist
Additional context
Although it works now, but I still wonder is this ok to just reuse the
sse_read_timeoutas timeout param for/messagesendpoint, or should I add a new param likemessages_read_timeoutforsse_client()?